-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support placeholder and selectable-overloads #190
feat: support placeholder and selectable-overloads #190
Conversation
The wait was worth it. :)
Guess we can just manually upgrade, whichever.
Right, you mentioned that. Can't say I have one but afaik this didn't seem critical.
Yeah, whatever. I mean, if I can help it things will move toward more granular type-level operations, but I wouldn't have others worry about that part at least. I suppose the github issue list should suffice to keep things current.
I had trouble pushing branches as orphan. If it'd do, it did work for non-orphan versions. If On that topic, @blakeembrey, could you invite @ikatyang into |
On |
|
Sorry, that's fine. I'd felt recent npm simplified things by handling exact version management without the extra dependency, but I don't have a strong preference otherwise; not sure what other considerations might be at play.
Uh, that's part of the |
Sorry, it does not need BRANCH=dist
git checkout --orphan $BRANCH
git commit --allow-empty -m "init"
git push --set-upstream origin $BRANCH |
Done! Edit: Tell me when I should merge this PR; I presume you want me to after you've added the branches. |
The last thing is about the
|
So we should enter a token in the repo settings huh? Let me try that... |
It's OK from you, but if that (Just need this repo's write access, but EDIT: (there's no way to generate |
I wish I could invite you into the org myself, but I fear I'd need to wait for @blakeembrey to respond there. It's good you already made the bot account at least. If he doesn't respond yet and so far I'm the closest account with a token with access though, might I be able to put a token into Travis? I presume it getting exposed would require them getting hacked or something. I guess the Travis account is yours? |
Since the
I'm not sure what you mean the Travis account? |
As in, where can I put this environment variable in? I can't seem to find a page in Github that looks like the one in your screenshot. 😅 |
It's on travis 😅, should be in https://travis-ci.org/types/npm-ramda |
Cool, added it in now! :) |
Thanks for inviting me to the @types org. 😀 Can you invite my bot account @ikatyang-bot to be a collaborator of this repo to deploy generated definitions automatically (just like this)? and set the I guess we can merge this PR now, and I'll replace the |
Sure, no problem. What exactly is the bot doing and would it be applicable to the wider organisation? If so, maybe we can find a better approach for you. |
The @ikatyang-bot is just for this repo's deployment: generated four version of the definitions and push them to their own branch: To clarify, this bot account is just for reducing the risk of Personal Access Token, since GitHub can only generate token for So that people can download which version they want via something like:
You can see my current deployment in my repo for example. EDIT: can you reduce the permission for my bot account to only access this repo (collaborator)? 😅 thanks. |
@tycho01 I've replaced the token on travis with my bot's token. |
cool, I've ditched the token; thanks! |
Fixes #173
Fixes #181
Fixes #120
Migrate from ikatyang/types-ramda v0.24.3, see discussion in #173.
To confirm:
travis: istypescript@next
still needed?GH_TOKEN
on travis to deploydist-*
branches automatically.dist
,dist-simple
,dist-selectable
anddist-placeholder
git checkout --orphan $branch-name
readme: I have no idea how to modify the roadmap.(seems no need to modify?)Future: